Clarify cloud database variable names#3004
Merged
adamtheturtle merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Rename variables and function names in admin/create_secrets_files.py to make it explicit which databases are cloud databases versus VuMark databases. Changes include: - _create_and_get_database_details -> _create_and_get_cloud_database_details - database_name/license_name -> cloud_database_name/cloud_license_name - database_details -> cloud_database_details - Generated resource names use "cloud" prefix for clarity This addresses the first item in issue #3002 to improve code clarity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors variable names in
admin/create_secrets_files.pyto make it explicit which databases are cloud databases versus VuMark databases. This improves code clarity by distinguishing between database types in variable naming conventions.Changes
_create_and_get_database_details()to_create_and_get_cloud_database_details()license_name→cloud_license_name,database_name→cloud_database_namedatabase_details→cloud_database_detailsRelated to
Issue #3002, first item
🤖 Generated with Claude Code
Note
Low Risk
Pure renaming/clarity refactor within an admin script; minimal behavior change risk aside from potential missed rename causing runtime errors.
Overview
Refactors
admin/create_secrets_files.pyto make it explicit which Vuforia resources are cloud databases vs VuMark resources.Renames
_create_and_get_database_detailsto_create_and_get_cloud_database_details, updates related parameter/local variable names (e.g.,license_name/database_name->cloud_license_name/cloud_database_name), and adjusts generated resource name prefixes and log messages accordingly; secrets file output values remain sourced from the same cloud database details.Written by Cursor Bugbot for commit 5fa142c. This will update automatically on new commits. Configure here.