-
Notifications
You must be signed in to change notification settings - Fork 2
Add test for inactive database in VuMark API #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4c73460
Add test for inactive database in VuMark generation API
adamtheturtle 27cf2b7
Move inactive database test to existing test file
adamtheturtle fe4e458
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 06eda4a
Use verify_mock_vuforia for inactive database test
adamtheturtle 33e9406
Merge main and use renamed inactive_cloud_database fixture
adamtheturtle e00aafa
Use inactive VuMark database fixture for TestInactiveDatabase
adamtheturtle 84e53c5
Merge remote-tracking branch 'origin/main' into adamtheturtle/add-lic…
adamtheturtle f54a377
Use keyword-only args in fixture functions to fix too-many-positional…
adamtheturtle 0c56b26
Fix inactive VuMark database to return UnknownTarget (404) not Projec…
adamtheturtle 8ebccc9
Add INACTIVE_VUMARK_VUFORIA_* to vuforia_secrets.env.example
adamtheturtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test asserts wrong error, doesn't test inactive behavior
Medium Severity
The docstring says "returns ProjectInactive" but the assertions check for
HTTPStatus.NOT_FOUNDandResultCodes.UNKNOWN_TARGET. Thevalidate_project_statefunction explicitly exemptsVuMarkDatabasefrom raisingProjectInactiveError(it always returns early), so the request falls through tovalidate_target_id_exists, which fails because the randomtarget_iddoesn't exist. This test doesn't actually verify inactive database behavior — it verifies unknown target behavior, which would produce the same result on an active database with a nonexistent target.Additional Locations (1)
src/mock_vws/_services_validators/project_state_validators.py#L59-L61