Use context manager for PIL Image.open to ensure proper resource cleanup#3000
Merged
adamtheturtle merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Image.open() was used without explicit close or context manager. When the source is a file stream (e.g. multipart upload), this can hold file handles until garbage collection. Prefer 'with Image.open(...) as img:' to ensure files are closed promptly. Fixes resource leak in: - image_matchers.py (StructuralSimilarityMatcher) - _query_validators/image_validators.py (validate_image_format, validate_image_dimensions, validate_image_is_image) - _services_validators/image_validators.py (validate_image_integrity, validate_image_format, validate_image_color_space, validate_image_is_image) - target.py (ImageTarget._post_processing_status) - target_raters.py (_get_brisque_target_tracking_rating) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image.open() was used without explicit close or context manager. When the source is a file stream (e.g. multipart upload), this can hold file handles until garbage collection. Prefer 'with Image.open(...) as img:' to ensure files are closed promptly.
Fixes resource leak in:
Note
Low Risk
Mechanical resource-cleanup change (context managers around
Image.open) with no functional logic changes expected beyond more deterministic file-handle release.Overview
Ensures
PIL.Image.openusages are wrapped in context managers across query validators, service validators, image matching, and target rating/status code paths so image/file handles are closed promptly.This updates image dimension/format/is-image checks, integrity verification, SSIM matching, BRISQUE-based rating, and target post-processing status to use
with Image.open(...) as ...(oras _) without changing validation thresholds or scoring logic.Written by Cursor Bugbot for commit 59e100d. This will update automatically on new commits. Configure here.