Skip to content

Enforce keyword-only arguments in make_image_file#2989

Merged
adamtheturtle merged 1 commit intomainfrom
enforce-kwonly-make-image-file
Feb 22, 2026
Merged

Enforce keyword-only arguments in make_image_file#2989
adamtheturtle merged 1 commit intomainfrom
enforce-kwonly-make-image-file

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 22, 2026

Summary

  • Add * to make_image_file in tests/mock_vws/utils/__init__.py to enforce keyword-only arguments, consistent with the project's conventions.
  • All existing call sites already use keyword arguments, so no other changes are needed.

Test plan

  • All pre-commit hooks pass.
  • Existing tests are unaffected since all callers already use keyword arguments.

Made with Cursor


Note

Low Risk
Small, test-only API tightening; risk is limited to breaking any unseen positional call sites.

Overview
Updates the test helper make_image_file to enforce keyword-only parameters by adding a * to its signature, preventing positional-argument usage and aligning with project conventions.

Written by Cursor Bugbot for commit dd70bfa. This will update automatically on new commits. Configure here.

Co-authored-by: Cursor <cursoragent@cursor.com>
@adamtheturtle adamtheturtle merged commit bcf3523 into main Feb 22, 2026
106 checks passed
@adamtheturtle adamtheturtle deleted the enforce-kwonly-make-image-file branch February 22, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant