Skip to content

Enforce keyword-only arguments in test helper#2987

Merged
adamtheturtle merged 1 commit intomainfrom
add-keyword-only-to-test-helpers
Feb 22, 2026
Merged

Enforce keyword-only arguments in test helper#2987
adamtheturtle merged 1 commit intomainfrom
add-keyword-only-to-test-helpers

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 22, 2026

Summary

  • Add * to _wait_for_target_processed in tests/mock_vws/fixtures/prepared_requests.py to enforce keyword-only arguments, preventing accidental positional usage
  • All existing call sites already use keyword arguments, so this is a non-breaking change

Test plan

  • Verify existing tests pass (all callers already use keyword args)

Made with Cursor


Note

Low Risk
Tiny signature tightening in test-only code; all current call sites already use keywords so impact should be minimal.

Overview
Enforces keyword-only arguments for the test helper _wait_for_target_processed in tests/mock_vws/fixtures/prepared_requests.py by adding * to its signature, preventing accidental positional calls.

Written by Cursor Bugbot for commit 92378da. This will update automatically on new commits. Configure here.

Add `*` to `_wait_for_target_processed` to require keyword-only
arguments, preventing accidental positional usage.

Co-authored-by: Cursor <cursoragent@cursor.com>
@adamtheturtle adamtheturtle merged commit 5922dba into main Feb 22, 2026
106 checks passed
@adamtheturtle adamtheturtle deleted the add-keyword-only-to-test-helpers branch February 22, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant