Use keyword-only parameters in tests#2986
Merged
adamtheturtle merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Enforce keyword-only arguments in test functions that accept multiple parameters, improving call-site clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*) in test functions that accept multiple parametersTest plan
Note
Low Risk
Mechanical test-signature change only; risk is limited to potential pytest collection/parametrization edge cases if any test relies on positional arguments.
Overview
This PR changes many pytest test functions (and one CI linter test) to enforce keyword-only parameters by adding
*to function signatures.No runtime behavior is intentionally changed; the update is a broad signature/style adjustment across the mock VWS test suite to make argument passing explicit and reduce accidental positional ordering mistakes.
Written by Cursor Bugbot for commit 4e311e6. This will update automatically on new commits. Configure here.