Skip to content

Use VuMarkService in VuMark generation API tests#2984

Merged
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/use-vws-vumark-tools
Feb 21, 2026
Merged

Use VuMarkService in VuMark generation API tests#2984
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/use-vws-vumark-tools

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 21, 2026

This updates VuMark generation API tests to use vws-python's VuMarkService and VuMarkAccept for client-level behavior checks. It converts the empty instance ID and non-VuMark target tests to assert typed vws exceptions (InvalidInstanceIdError and InvalidTargetTypeError) and inspect their responses. It keeps raw signed requests where direct protocol/header control is required and adds a dedicated test for response Content-Type across PNG/SVG/PDF formats. The PR diff is limited to tests/mock_vws/test_vumark_generation_api.py.


Note

Low Risk
Test-only changes that primarily refactor assertions and add a header check; no production logic or security-sensitive code is modified.

Overview
Updates VuMark generation API tests to exercise the vws client surface: generation now uses VuMarkService.generate_vumark_instance with typed VuMarkAccept values, and the format test validates returned bytes by file signature.

Error-path coverage is shifted from raw HTTP assertions to asserting InvalidInstanceIdError/InvalidTargetTypeError exceptions and inspecting their embedded HTTP responses. Raw signed requests are retained where direct header control is needed, with a new dedicated test that validates the Content-Type header for PNG/SVG/PDF responses.

Written by Cursor Bugbot for commit 2c781a2. This will update automatically on new commits. Configure here.

@adamtheturtle adamtheturtle merged commit 4dbfbf4 into main Feb 21, 2026
102 of 103 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/use-vws-vumark-tools branch February 21, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant