Use VuMarkService in VuMark generation API tests#2984
Merged
adamtheturtle merged 2 commits intomainfrom Feb 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates VuMark generation API tests to use vws-python's VuMarkService and VuMarkAccept for client-level behavior checks. It converts the empty instance ID and non-VuMark target tests to assert typed vws exceptions (InvalidInstanceIdError and InvalidTargetTypeError) and inspect their responses. It keeps raw signed requests where direct protocol/header control is required and adds a dedicated test for response Content-Type across PNG/SVG/PDF formats. The PR diff is limited to tests/mock_vws/test_vumark_generation_api.py.
Note
Low Risk
Test-only changes that primarily refactor assertions and add a header check; no production logic or security-sensitive code is modified.
Overview
Updates VuMark generation API tests to exercise the
vwsclient surface: generation now usesVuMarkService.generate_vumark_instancewith typedVuMarkAcceptvalues, and the format test validates returned bytes by file signature.Error-path coverage is shifted from raw HTTP assertions to asserting
InvalidInstanceIdError/InvalidTargetTypeErrorexceptions and inspecting their embedded HTTP responses. Raw signed requests are retained where direct header control is needed, with a new dedicated test that validates theContent-Typeheader for PNG/SVG/PDF responses.Written by Cursor Bugbot for commit 2c781a2. This will update automatically on new commits. Configure here.