-
Notifications
You must be signed in to change notification settings - Fork 2
Create VuMarkTarget type for semantically correct VuMark fixture #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
787bbe3
Create VuMarkTarget type for semantically correct VuMark fixture
adamtheturtle 2546071
Fix type issues with get_target returning image targets only
adamtheturtle 2c9bb90
Fix mypy type hint for not_deleted_targets union
adamtheturtle 32d40f5
Separate VuMark database from CloudDatabase and minimize VuMarkTarget
adamtheturtle 949599f
Fix Sphinx docs reference to renamed endpoint
adamtheturtle c00b1c2
Split TargetManager.databases into typed cloud_databases and vumark_d…
adamtheturtle 1b39573
Merge remote-tracking branch 'origin/main' into adamtheturtle/fix-vum…
adamtheturtle 0f8240d
Merge remote-tracking branch 'origin/main' into adamtheturtle/fix-vum…
adamtheturtle 1e110eb
Revert unnecessary changes to cloud-specific functions
adamtheturtle bc3e107
Revert cosmetic changes to existing code
adamtheturtle ec58b55
Fix VuMark auth by widening validators to accept both database types
adamtheturtle a762cd9
Address bugbot review: scope validate_request to cloud-only databases
adamtheturtle dfbb55f
Update tests to match new database conflict error message
adamtheturtle 92650f8
Fix coverage: remove dead VuMark branches, add duplicate key tests
adamtheturtle ac4bcb2
Fix VuMark duplicate keys test isolation in Flask tests
adamtheturtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing error handling in VuMark database deletion endpoint
Medium Severity
The
delete_vumark_databaseendpoint lacks thetry/except ValueErrorerror handling thatdelete_cloud_databasehas. When no matching VuMark database exists for the given name, the set unpacking(matching_database,) = {...}raises an unhandledValueError, resulting in a 500 error instead of the intended 404 response.