Add VuMark support and refresh Vuforia secrets#2965
Closed
adamtheturtle wants to merge 3 commits intomainfrom
Closed
Add VuMark support and refresh Vuforia secrets#2965adamtheturtle wants to merge 3 commits intomainfrom
adamtheturtle wants to merge 3 commits intomainfrom
Conversation
Add DatabaseType enum (CLOUD_RECO, VUMARK) to distinguish database types and TargetType enum (IMAGE, VUMARK_TEMPLATE) for target classification. Implement InvalidTargetTypeError in VuMark generation endpoints to validate that VuMark instance generation only works on VUMARK-type databases. Update database and target serialization to include type information, and allow pre-population of VuMark targets in VuMark-type databases. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
… class Add autoenum entries for DatabaseType and TargetType to the API reference docs. Add a docstring note to Target clarifying that some attributes are primarily meaningful for image targets rather than VuMark template targets. Add vulture whitelist entries for the new TypedDict field and enum value. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…resh Vuforia secrets ## Summary - Add `DatabaseType` and `TargetType` enums to support cloud and VuMark databases - Implement VuMark target validation, generation, and database operations - Optimize secrets creation script to reuse VuMark/inactive credentials - Bump vws-web-tools to 2026.2.20 for improved stability - Refresh encrypted secrets archive with 100 new cloud database credentials ## Key Changes - New `database_type.py` and enhanced `target.py` with TargetType support - VuMark endpoint implementation in Flask and requests-mock servers - Target type validation in endpoints and database - Simplified admin script: creates only new cloud databases, reuses VuMark/inactive databases - Updated secrets.tar.gpg with fresh 2026-02-20 licenses Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| name=name, | ||
| active_flag=active_flag, | ||
| last_modified_date=last_modified_date, | ||
| ) |
There was a problem hiding this comment.
Inconsistent application_metadata null validation for VuMark targets
Medium Severity
The application_metadata is None validation in the requests-mock update_target was moved inside the isinstance(target, ImageTarget) block, so it's skipped for VuMarkTarget. However, the Flask VWS update_target validates application_metadata is None for all target types (lines 686–696 of vws.py). This creates a behavioral difference between the two mock backends: sending {"application_metadata": null} when updating a VuMark target returns BAD_REQUEST on the Flask/Docker backend but OK on the requests-mock backend.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive VuMark database and target type support to the mock, optimizes the secrets creation script, and refreshes the encrypted secrets archive with 100 new cloud database credentials to replace the suspended license.
Key Changes
DatabaseTypeandTargetTypeenums supporting cloud and VuMark databasesTest Coverage
VuMark generation API tests updated to verify database type handling. All existing tests passing with new credentials.
🤖 Generated with Claude Code
Note
Medium Risk
Touches core mock API request paths and persistence (
VuforiaDatabase/target models), so type-handling regressions could affect multiple endpoints; changes are contained to mock behavior and are covered by updated tests.Overview
Adds first-class VuMark support by introducing
DatabaseTypeand splitting targets intoImageTarget(renamed fromTarget) and a newVuMarkTarget, withVuforiaDatabaseserialization/deserialization updated to persist mixed target types and a database type.Updates both the Flask and
requests-mockVWS/Target Manager implementations to handle creating/updating/deleting VuMark vs image targets, gate/targets/<id>/instancestoDatabaseType.VUMARK, and return sensible placeholder fields for non-image targets; also restricts query/duplicate matching toImageTargetonly.Simplifies
admin/create_secrets_files.pyto only provision new cloud databases while reusing existing inactive/VuMark secrets from env, bumpsvws-web-toolsversion, refreshes docs/API reference, and extends tests to coverInvalidTargetTypefor VuMark generation on non-VuMark databases.Written by Cursor Bugbot for commit 31a2332. This will update automatically on new commits. Configure here.