Remove unused default VuMark target ID#2948
Merged
adamtheturtle merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
The default "MockVuMarkTargetID00" is never used since vuforia_secrets.env is always required (other settings have no defaults) and always provides VUMARK_VUFORIA_TARGET_ID. Update example env to use placeholder like other fields. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused default
"MockVuMarkTargetID00"from_VuMarkVuforiaDatabaseSettings. This default was never used in practice sincevuforia_secrets.envis always required (other fields in the same settings class have no defaults) and always providesVUMARK_VUFORIA_TARGET_ID.Update the example env file to use a placeholder
<VUMARK_TARGET_ID>for consistency with other fields.🤖 Generated with Claude Code
Note
Low Risk
Test/fixture and documentation-only change; risk is limited to environments that relied on the removed default and now must set
VUMARK_VUFORIA_TARGET_ID.Overview
Removes the hardcoded default for
VUMARK_VUFORIA_TARGET_IDin_VuMarkVuforiaDatabaseSettings, making the VuMark target ID a required env-provided setting for the test fixtures.Updates
vuforia_secrets.env.exampleto use a<VUMARK_TARGET_ID>placeholder instead of the previous mock default value.Written by Cursor Bugbot for commit d3f2a36. This will update automatically on new commits. Configure here.