Add tenacity retries to secrets file creation#2934
Merged
adamtheturtle merged 5 commits intomainfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates admin/create_secrets_files.py to use explicit tenacity retry policies for timeout-prone Selenium operations. Database and VuMark creation/detail retrieval now raise TimeoutException and are wrapped with retries that stop after three attempts with exponential backoff. The main loop now handles exhausted retries by resetting the driver and continuing to the next attempt, preserving the existing workflow while making retry behavior bounded and clearer. The tenacity call signatures were adjusted to keyword arguments to satisfy strict mypy checks in pre-push hooks.
Note
Low Risk
Low risk: this only adjusts retry/timeout handling in an admin Selenium script, with bounded attempts and no production-path data/auth changes.
Overview
Improves robustness of
admin/create_secrets_files.pyby adding tenacity-based retries (3 attempts, exponential backoff) for timeout-prone Selenium calls when fetching Vuforia database and VuMark details.Removes the previous
None-return-on-timeout flow and instead raisesTimeoutExceptionafter retries, with the main loop catching exhausted retries, resetting the Chrome driver, and continuing to the next file creation attempt.Written by Cursor Bugbot for commit 8e9ddd0. This will update automatically on new commits. Configure here.