Add tenacity retries to secrets file creation#2933
Merged
adamtheturtle merged 5 commits intomainfrom Feb 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates admin/create_secrets_files.py to use explicit tenacity retry policies for timeout-prone Selenium operations. Database and VuMark creation/detail retrieval now raise TimeoutException and are wrapped with retries that stop after three attempts with exponential backoff. The main loop now handles exhausted retries by resetting the driver and continuing to the next attempt, preserving the existing workflow while making retry behavior bounded and clearer. The tenacity call signatures were adjusted to keyword arguments to satisfy strict mypy checks in pre-push hooks.
Note
Low Risk
Low risk: changes are limited to an admin script and mainly adjust timeout handling by retrying and failing fast after bounded attempts.
Overview
Makes secrets-file generation more resilient to flaky Selenium timeouts by introducing a shared tenacity
RETRY_ON_TIMEOUTpolicy (3 attempts with exponential backoff) around database/VuMark detail retrieval.Refactors helper functions to always return details (no
None) and letsTimeoutExceptionpropagate after retries; the main loop now catches exhausted timeouts, logs a clearer error, resets the web driver, and continues to the next file.Written by Cursor Bugbot for commit 7604f0f. This will update automatically on new commits. Configure here.