-
Notifications
You must be signed in to change notification settings - Fork 2
Add VuMark Generation API endpoint (#473) #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3efd7a7
Add VuMark Generation API endpoint (#473)
adamtheturtle 139282e
Fix type annotations and mypy errors
adamtheturtle f193a40
Fix pylint spelling errors in VuMark implementation
adamtheturtle dcb8ec3
Refactor VuMark tests to use verify_mock_vuforia fixture
adamtheturtle a24762c
Fix BugBot issues in VuMark image generators
adamtheturtle e2db9b5
Remove unnecessary .encode() on error paths in VuMark endpoint
adamtheturtle 0edf26a
Use mock_only_vuforia for VuMark tests
adamtheturtle 3c6ec7b
Add VuMark validation and related test updates
adamtheturtle 99fef3e
Fix manual CI pylint failures for VuMark generation
adamtheturtle 37095d4
Address PR #2878 Bugbot follow-up findings
adamtheturtle 7704c8b
Fix mypy typing in PR #2878 regression test
adamtheturtle 4ee8d50
Use unittest patch for typed target-id regression test
adamtheturtle b536a1d
Address PR #2878 review comments
adamtheturtle fc1e301
Merge remote-tracking branch 'origin/main' into adamtheturtle/remove-…
adamtheturtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ResponseTypein decorators not updated for bytesMedium Severity
The
_ResponseTypeinmock_web_services_api.pywas updated tostr | bytesto support the vumark endpoint returning binary content, but the corresponding_ResponseTypeindecorators.pystill usesstr. The_Callbacktype andwrappedfunction's return annotation in_wrap_callbackincorrectly claim onlystrbodies are supported. This type mismatch could cause static type checker failures and is misleading.