change _create_modelsim_ini() and add ini_flag="ini" for questsim>=ve…#1134
Open
asicnet wants to merge 1 commit intoVUnit:masterfrom
Open
change _create_modelsim_ini() and add ini_flag="ini" for questsim>=ve…#1134asicnet wants to merge 1 commit intoVUnit:masterfrom
asicnet wants to merge 1 commit intoVUnit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In File modelsim.py method _create_modelsim_ini
Many problems arise when libraries already exist or when certain files—usually protected—need to be precompiled. This can be solved with env. VUNIT_MODELSIM_INI, but not if modelsim.ini changes after vunit compile or even during it. The initial modelsim.ini must first be adjusted again because vunit creates a new modelsim each time. This is a hindrance for very complex designs.
Therefore, the suggestion is NOT to overwrite modelsim.ini if it already exists.
Questasim change the option for modelsim.ini from -modelsimini to -ini.
So add a member ini_flag and change all -modelsimini to f"{self.ini_flag} and add a version check if vsim < 2025 for modelsimini