Localize security mode decision copy#1
Open
jerryfan wants to merge 1 commit intoVTSTech:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security mode flow has several decision points where wording affects whether a user relaxes or tightens enforcement: current mode, basic vs max differences, mode-change warnings, invalid mode, and the TUI-only audit message.
This PR makes just that security-mode decision copy optionally localizable while preserving the existing English strings as fallbacks.
What changed:
extensions/i18n.tses,fr, andpt-BRstrings for security-mode/audit decision copy/security modeand/security-audituser-facing strings that directly affect enforcement decisionsWhat did not change:
extensions/i18n.tsand the small wrappers inextensions/security.tsValidation:
npx esbuild extensions/security.ts --bundle --platform=node --format=esm --outfile=... --external:@mariozechner/pi-coding-agentpassednpx tsx --test tests/*.test.tsran; existing Windows path expectation failures remain in security path tests (/tmp,/home, cwd), unrelated to these string changesnpm run typecheckis currently blocked by existing repo-wide type issues/missing ambient deps before this change (@mariozechner/pi-coding-agent, node types, existing strict errors)If useful later, I’m happy to handle broader localization in small follow-up PRs using whatever locale set you prefer.