fix(search): keep Insert mode when starting search fixes #8908#9971
Open
bearylabs wants to merge 1 commit intoVSCodeVim:masterfrom
Open
fix(search): keep Insert mode when starting search fixes #8908#9971bearylabs wants to merge 1 commit intoVSCodeVim:masterfrom
bearylabs wants to merge 1 commit intoVSCodeVim:masterfrom
Conversation
Prevent search-start selection updates from forcing a mode switch to Visual. Keep Insert mode active while still updating cursor/selection state for command-driven selections. This fixes the regression where starting search entered Visual mode unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a regression where starting search while in Insert mode could switch the editor into Visual mode unexpectedly.
The fix keeps Insert mode active when search starts, while still updating cursor and selection state correctly for command-driven selections.
Which issue(s) this PR fixes
fixes #8908
fixes #9516