Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/debian.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
build-linux:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- os: buster
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
brew install python@3.13 re2c coreutils libiconv googletest shivammathur/php/php@7.4
brew link --overwrite --force shivammathur/php/php@7.4
brew link --overwrite --force python@3.13
/opt/homebrew/opt/python@3.13/libexec/bin/python -m pip install --upgrade pip --user --break-system-packages && /opt/homebrew/opt/python@3.13/libexec/bin/pip install --break-system-packages jsonschema six cmake==3.31.6
/opt/homebrew/opt/python@3.13/libexec/bin/python -m pip install --upgrade pip --user --break-system-packages && /opt/homebrew/opt/python@3.13/libexec/bin/pip install --break-system-packages jsonschema cmake==3.31.6

- name: Run cmake
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
build-linux:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- os: focal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ wget -qO - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -
Install packages
```bash
apt-get update
apt install git cmake-data=3.18* cmake=3.18* make patch re2c g++ gperf python3-minimal python3-jsonschema python3-six \
apt install git cmake-data=3.18* cmake=3.18* make patch re2c g++ gperf python3-minimal python3-jsonschema \
libfmt-dev libgtest-dev libgmock-dev \
zlib1g-dev php7.4-dev libldap-dev libkrb5-dev \
libpq5=14.* postgresql-14 postgresql-server-dev-14 libpq-dev=14.* composer
Expand All @@ -71,7 +71,7 @@ Install packages
```bash
apt-get update
apt install git cmake make g++ gperf netcat patch re2c \
python3.7 python3-pip python3.7-distutils python3.7-dev libpython3.7-dev python3-jsonschema python3-setuptools python3-six \
python3.7 python3-pip python3.7-distutils python3.7-dev libpython3.7-dev python3-jsonschema python3-setuptools \
libfmt-dev libgtest-dev libgmock-dev \
zlib1g-dev php7.4-dev libldap-dev libkrb5-dev mysql-server libmysqlclient-dev \
libpq5=14.* postgresql-14 postgresql-server-dev-14 libpq-dev=14.* composer
Expand All @@ -86,7 +86,7 @@ brew tap shivammathur/php
brew update
brew install python@3.13 re2c cmake coreutils libiconv googletest shivammathur/php/php@7.4
brew link --overwrite shivammathur/php/php@7.4
python3.13 -m pip install jsonschema six
python3.13 -m pip install jsonschema

# Build kphp
git clone https://github.com/VKCOM/kphp.git && cd kphp
Expand Down
1 change: 0 additions & 1 deletion tests/python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ pytest-postgresql==4.1.1
psycopg==3.1.9
pytest-xdist==3.3.1
zstandard==0.21.0
six==1.17.0
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
Should use Python's native function instead of the six package for unicode.py

---
diff --git a/re2/unicode.py b/re2/unicode.py
index e0f33ef..651b7cc 100644
--- a/re2/unicode.py
+++ b/re2/unicode.py
@@ -10,7 +10,6 @@

import os
import re
-from six.moves import urllib

# Directory or URL where Unicode tables reside.
_UNICODE_DIR = "${UNICODE_AUTO_RAW_DATA_DIR}"
@@ -152,10 +151,7 @@
raise InputError("invalid number of fields %d" % (nfields,))

if type(filename) == str:
- if filename.startswith("https://"):
- fil = urllib.request.urlopen(filename)
- else:
- fil = open(filename, "rb")
+ fil = open(filename, "rb")
else:
fil = filename
1 change: 1 addition & 0 deletions third-party/re2-cmake/patches/series
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
kphp-unicode-data.patch
kphp-remove-six-package.patch
1 change: 0 additions & 1 deletion third-party/re2-cmake/re2.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
check_python_package(six)
update_git_submodule(${THIRD_PARTY_DIR}/re2 "--recursive")
get_submodule_version(${THIRD_PARTY_DIR}/re2 RE2_VERSION)
get_submodule_remote_url(third-party/re2 RE2_SOURCE_URL)
Expand Down
Loading