add return statements in wait_concurrently as in kphp #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrophysik
changed the title
astrophysik
changed the title
astrophysik
changed the title
DrDet
reviewed
Oct 1, 2022
Contributor
DrDet
left a comment
DrDet
left a comment
There was a problem hiding this comment.
Very strange logic inside the function.
| return wait($id); | ||
| } | ||
|
|
||
| function wait_concurrently($id) { |
Contributor
There was a problem hiding this comment.
Did you figure out what's going on in this function?
As far as I can see, it always requests undefined index at line 333, and the condition !$waiting[$id] is always true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return statements for errors and for successful completion