Skip to content

Conversation

@GernotMaier
Copy link
Member

No description provided.

@GernotMaier GernotMaier self-assigned this Jan 11, 2026
@GernotMaier GernotMaier requested a review from Copilot January 11, 2026 19:15
@GernotMaier GernotMaier marked this pull request as ready for review January 11, 2026 19:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds functionality to support XGB (XGBoost) stereo reconstruction in the VERITAS event display system. The changes update various scripts to handle two separate XGB file suffixes for stereo reconstruction and gamma-hadron separation, replace the old single XGB version variable with these two new suffixes, and add support for XGB-based cut definitions in the analysis pipeline.

Changes:

  • Replaced single XGBVERSION variable with XGBSTEREOFILESUFFIX and XGBGAMMAHADRONFILESUFFIX variables for handling two types of XGB files
  • Added XGB reconstruction method settings that automatically configure direction and energy reconstruction when XGB cuts are detected
  • Fixed zenith angle calculations and comparisons by switching from elevation to zenith angle and using floating-point arithmetic instead of integer comparisons
  • Added four new XGB-based cut definitions (moderate2telXGB, soft2telXGB, hard2telXGB, hard3telXGB)

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/helper_scripts/IRF.effective_area_parallel_sub.sh Refactored XGB file handling to support two XGB file types, added loop to copy both XGB files, and added XGB reconstruction method configuration
scripts/helper_scripts/ANALYSIS.mscw_energy_sub.sh Fixed zenith angle calculation by switching from elevation to zenith parameter and updated comparisons to use floating-point arithmetic
scripts/helper_scripts/ANALYSIS.dispXGB_sub.sh Updated zenith angle comparisons from integer to floating-point arithmetic for consistent behavior
scripts/IRF.production.sh Updated documentation to include additional CARE simulation types
scripts/IRF.generate_effective_area_parts.sh Updated XGB variable names and corresponding sed replacements to support two XGB file suffixes
scripts/ANALYSIS.anasum_parallel_from_runlist.sh Added four new XGB cut definitions and cleaned up HTCondor submission output messages
docs/changes/135.feature.md Added changelog entry documenting the new XGB functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier merged commit 6845370 into main Jan 11, 2026
1 check passed
@GernotMaier GernotMaier deleted the v492-dev12 branch January 11, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants