v492 14 xgb gh #337
Merged
v492 14 xgb gh #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the XGBoost integration in the codebase by separating stereo reconstruction and gamma-hadron separation functionalities into two distinct XGB file suffixes. The changes refactor how XGB data files are loaded and accessed, introducing a more modular approach.
Changes:
- Split single XGB file suffix parameter into two separate parameters:
fXGB_stereo_file_suffixfor stereo analysis andfXGB_gh_file_suffixfor gamma-hadron classification - Refactored CData class to manage two separate friend trees (stereo and gamma-hadron) instead of one
- Added XGBoost gamma-hadron separation analysis type (selector 52) with support for 70% signal efficiency cuts
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| inc/CData.h | Updated to support two friend trees (stereo and gamma-hadron) with new constructor signatures and getter methods |
| inc/VAnaSumRunParameter.h | Split fXGB_file_suffix into fXGB_stereo_file_suffix and fXGB_gh_file_suffix |
| inc/VGammaHadronCuts.h | Added XGBoostAnalysis enum type and useXGBoostCuts() method, incremented ClassDef version |
| inc/VInstrumentResponseFunctionRunParameter.h | Split fXGB_file_suffix into two separate suffix parameters |
| inc/VStereoAnalysis.h | Removed XGB file member variables (moved to CData) |
| src/CData.cpp | Added two constructors, XGB tree loading logic, and initialization methods for friend trees |
| src/VGammaHadronCuts.cpp | Implemented XGBoost cut application logic with 70% signal efficiency threshold |
| src/VAnaSumRunParameter.cpp | Updated parameter reading to handle both stereo and gamma-hadron file suffixes |
| src/VInstrumentResponseFunctionRunParameter.cpp | Updated parameter reading and printing for split XGB suffixes |
| src/VStereoAnalysis.cpp | Removed inline XGB file handling, delegated to CData constructor |
| src/makeEffectiveArea.cpp | Updated CData instantiation to use new constructor with separate suffixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(Re-)introduce energy and direction method selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.