-
Notifications
You must be signed in to change notification settings - Fork 12
fix: consentMediation map value #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA bug fix in an iOS extension that corrects the dictionary key used to read the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR Summary: Fixes an error where the "consentMediation" value was mapped using the wrong dictionary key. The change now properly retrieves a Boolean value from the "consentMediation" key instead of "networkMode". |
| } | ||
|
|
||
| if let consentMediationValue = dictionary["networkMode"] as? Bool { | ||
| if let consentMediationValue = dictionary["consentMediation"] as? Bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[REFACTORING] The patch correctly updates the key from 'networkMode' to 'consentMediation', which aligns with the expected mapping (see reference code block at ios/Extensions/UsercentricsOptions+Dict.swift, lines 28-34 and sample tests). Ensure that any associated logic or tests that depend on 'consentMediation' properly reflect this change to avoid potential regressions.
|
Reviewed up to commit:e38d1ce4dec885b62454e39324c9546a25191dab |
Summary by CodeRabbit