feat: add CSRF token normalization for Django record/replay#57
Merged
Conversation
There was a problem hiding this comment.
3 issues found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/django/middleware.py">
<violation number="1" location="drift/instrumentation/django/middleware.py:282">
P2: Normalizing the response body without checking Content-Encoding can corrupt compressed HTML responses (e.g., gzip), since the body is decoded as UTF-8 regardless of encoding. Skip normalization unless the response is uncompressed/identity.</violation>
<violation number="2" location="drift/instrumentation/django/middleware.py:341">
P2: Span capture normalizes HTML bodies without checking Content-Encoding, which can corrupt compressed responses when decoding/re-encoding gzip/deflate payloads. Guard normalization to only run on uncompressed content.</violation>
</file>
<file name="drift/instrumentation/django/csrf_utils.py">
<violation number="1" location="drift/instrumentation/django/csrf_utils.py:37">
P2: Decoding with `errors="ignore"` can silently drop invalid bytes and mutate non‑UTF8 response bodies. Since you already catch decode errors, use strict decoding so non‑UTF8 bodies are returned unchanged.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
sohil-kshirsagar
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CSRF token normalization to the Django instrumentation to ensure consistent record/replay testing. Django CSRF tokens are dynamically generated, meaning they differ between recording and replay, causing comparison failures for any HTML form containing CSRF tokens.
Changes
csrf_utils.pymodule withnormalize_csrf_in_body()function that replaces CSRF tokens with a fixed placeholder (__DRIFT_CSRF__)middleware.pyto normalize CSRF tokens in two places:/api/csrf-formendpoint that returns an HTML form with a CSRF token