Skip to content

fix: only treat HTTP 4xx+ responses as errors#117

Merged
sohankshirsagar merged 1 commit intomainfrom
sohan/update-error-classification
Jan 19, 2026
Merged

fix: only treat HTTP 4xx+ responses as errors#117
sohankshirsagar merged 1 commit intomainfrom
sohan/update-error-classification

Conversation

@sohankshirsagar
Copy link
Contributor

@sohankshirsagar sohankshirsagar commented Jan 19, 2026

Note

Aligns error status handling across instrumentations and expands acceptable response types.

  • Change error threshold from >=300 to >=400 when setting span status in fetch, http (client/server), and nextjs instrumentations
  • Update replay/exported span status fields to use >=400 for StatusCode.ERROR
  • Add DecodedType.HTML to ACCEPTABLE_CONTENT_TYPES to avoid blocking HTML responses

Written by Cursor Bugbot for commit 3860b88. This will update automatically on new commits. Configure here.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@sohankshirsagar sohankshirsagar merged commit a9d07c8 into main Jan 19, 2026
16 checks passed
@sohankshirsagar sohankshirsagar deleted the sohan/update-error-classification branch January 19, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants