fix: filter coordinates kwargs to prevent TypeError in hi_res PDF processing #4206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@badGarnet could you please take a look at the PR I mentioned earlier? really appreciate your time and feedback. |
Collaborator
please add a unit test and remember to bump version number |
MkDev11
force-pushed
the
fix/coordinates-kwarg-4126
branch
from
f7c3d98 to
bd4e320
Compare
…cessing Filter out 'coordinates' and 'coordinate_system' from kwargs before passing to add_element_metadata() to prevent conflict with explicit parameters. When users pass coordinates=True to partition_pdf with hi_res strategy, this boolean value could conflict with the explicit coordinates parameter which expects tuple data, causing TypeError. Fixes Unstructured-IO#4126
MkDev11
force-pushed
the
fix/coordinates-kwarg-4126
branch
from
bd4e320 to
97a06cd
Compare
Contributor
Author
|
@badGarnet updated again! could you please have a look at the changes and let me know ther result? appeciate for your time! |
badGarnet
approved these changes
Jan 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
The CI's docker-build step fails because the Dockerfile tries to create a symlink python3 but it already exists (Python 3.12 installation created it). |
The libreoffice package brings in python-3.13-base which creates a /usr/bin/python3 symlink. The previous conditional check '[ -e ... ] || ln -s' failed because -e returns false for broken symlinks, but ln still fails because the symlink name exists. Using ln -sf forces the symlink to be overwritten regardless of its state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where passing
coordinates=Truetopartition()causes a TypeError when processing PDFs with the hi_res strategy.Problem
When users call
partition()withcoordinates=True, the boolean value flows through kwargs and eventually reachesadd_element_metadata(). However, this function already receives computed coordinate data as an explicit parameter. Python then raises:This is confusing because users reasonably expect
coordinates=Trueto enable coordinate output, not realizing that hi_res strategy already computes and includes coordinates automatically.Solution
Filter out
coordinatesandcoordinate_systemfrom kwargs before passing them toadd_element_metadata(). This prevents the conflict while preserving the internally-computed coordinate data.The fix is minimal and targeted - just 3 lines of code that filter the problematic kwargs.
Changes
unstructured/partition/pdf.py: Added filtering forcoordinatesandcoordinate_systemkwargsCHANGELOG.md: Added entry for this fixFixes #4126