UnifiedNetcodeTransport refactor#3976
Open
ShadauxCat wants to merge 9 commits intoexperimental/v3-x-x/unified-poc-migrationfrom
Open
UnifiedNetcodeTransport refactor#3976ShadauxCat wants to merge 9 commits intoexperimental/v3-x-x/unified-poc-migrationfrom
ShadauxCat wants to merge 9 commits intoexperimental/v3-x-x/unified-poc-migrationfrom
Conversation
…odeTransport to not use entities (#3943) Refactor sending and receiving of RPCs to not use entities, thereby preserving send/receive order without having to encode an order value and reorder messages on the receive side.
…ybrid_spawn_integration_tests
ShadauxCat
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
…ental/v3-x-x/hybrid_spawn_integration_tests
ShadauxCat
changed the title
…migration' into experimental/v3-x-x/hybrid_spawn_integration_tests # Conflicts: # com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs # com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NetcodeIntegrationTest.cs # testproject/Assets/Tests/Manual/DontDestroyOnLoad/ObjectToNotDestroyBehaviour.cs
ShadauxCat
changed the title
Comment on lines
+474
to
+482
| #if UNIFIED_NETCODE | ||
| if (!NetworkConfig.Prefabs.HasGhostPrefabs) | ||
| { | ||
| #endif | ||
| // Process outbound messages | ||
| MessageManager.ProcessSendQueues(); | ||
| #if UNIFIED_NETCODE | ||
| } | ||
| #endif |
Member
There was a problem hiding this comment.
Suggested change
| #if UNIFIED_NETCODE | |
| if (!NetworkConfig.Prefabs.HasGhostPrefabs) | |
| { | |
| #endif | |
| // Process outbound messages | |
| MessageManager.ProcessSendQueues(); | |
| #if UNIFIED_NETCODE | |
| } | |
| #endif | |
| #if !UNIFIED_NETCODE | |
| // Process outbound messages | |
| MessageManager.ProcessSendQueues(); | |
| #endif |
Member
There was a problem hiding this comment.
Perhaps leave an XML comment with a cref to UnifiedNetcodeUpdateSystem.Update saying something about messages being processed prior to when N4E sends them?
NoelStephensUnity
approved these changes
May 8, 2026
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Other than the minor define suggestion and comment about where the send queue is processing, it looks very nice Kitty!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just #3943 with some fixes to issues exposed by unit tests.