fix: networklog can throw exception when no networkmanager exists#3917
Open
NoelStephensUnity wants to merge 5 commits intodevelop-2.0.0from
Open
fix: networklog can throw exception when no networkmanager exists#3917NoelStephensUnity wants to merge 5 commits intodevelop-2.0.0from
NoelStephensUnity wants to merge 5 commits intodevelop-2.0.0from
Conversation
Fixing exception that could be thrown in NetworkLog if there is no NetworkManager instance. Adding additional check in NetworkObject.OnNetworkBehaviourDestroyed to assure nothing is ever logged about destroying a NetworkBehaviour when shutting down and the NetworkObject is still considered spawned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The purpose of this PR is to resolve the issue where attempting to use
NetworkLogwhen there is noNetworkManagerinstance would result in an exception.Jira ticket
MTT-14743
fix: #3911
Changelog
NetworkLogwhen there is noNetworkManagerinstance would result in an exception.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport is required.