fix: RPC metrics name table is empty#3782
Merged
NoelStephensUnity merged 18 commits intodevelop-2.0.0from Nov 17, 2025
Merged
Conversation
Improving our defines that determine if metrics should be gathered. 1st pass attempt at unifying this process. The primary change is that if the __rpc_name_table is not built (yet) when an RPC is invoked that it will attempt to build it for that specific NetworkBehaviour prior to attempting to log RPC metrics.
FelixWentworth-Unity
left a comment
FelixWentworth-Unity
left a comment
There was a problem hiding this comment.
Tested replication project provided with NGO 2.5.0, 2.5.1. 2.6.0, 2.7.0 & these changes and can verify that this PR fixes the issues seen in 2.6.0 and 2.7.0.
com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/ProxyRpcTargetGroup.cs
Show resolved
Hide resolved
FelixWentworth-Unity
approved these changes
Nov 14, 2025
FelixWentworth-Unity
left a comment
FelixWentworth-Unity
left a comment
There was a problem hiding this comment.
Tested & verified - Looks good!
noellie-velez
approved these changes
Nov 14, 2025
Collaborator
noellie-velez
left a comment
noellie-velez
left a comment
There was a problem hiding this comment.
Nice fix and cleanup! 🚀
miniwolf
approved these changes
Nov 17, 2025
Collaborator
miniwolf
left a comment
miniwolf
left a comment
There was a problem hiding this comment.
QA Review: New automated test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes the issue where __rpc_name_table was not built (yet) when an RPC, located on another
NetworkBehaviourthat is ordered later than the invokingNetworkBehaviour, is invoked duringOnNetworkSpawnand scene management is disabled.This PR includes some re-organization:
NetworkBehaviour.fix: #3742
Jira ticket
MTTB-1734
Changelog
NetworkBehaviourassociated with the sameNetworkObjectthat is ordered before theNetworkBehaviourwith the RPC and scene management is disabled could throw an exception.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsRpcDuringOnNetworkSpawnDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No back port is required.