CMCL-1694: Fix blend reversal logic and add unit test #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the handling of reversing a blend-in-progress in CameraBlendStack by tracking the normalized blend position and adjusting the blend duration accordingly. Adds a comprehensive unit test in BlendManagerTests to verify correct behavior when repeatedly reversing blends between cameras.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage ? 27.35%
=======================================
Files ? 256
Lines ? 28834
Branches ? 0
=======================================
Hits ? 7888
Misses ? 20946
Partials ? 0
🚀 New features to boost your workflow:
|
alexzaranek
approved these changes
Jul 16, 2025
Contributor
alexzaranek
left a comment
alexzaranek
left a comment
There was a problem hiding this comment.
Changes look good and work well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes CMCL-1694. See ticket for a test project.
Improves the handling of reversing a blend-in-progress in CameraBlendStack by tracking the normalized blend position and adjusting the blend duration accordingly. Adds a comprehensive unit test in BlendManagerTests to verify correct behavior when repeatedly reversing blends between cameras.
Testing status
Documentation status
Technical risk
low