Skip to content

Conversation

@Oginternational
Copy link

Purpose of this PR

[Description of the feature/changes. Links to screenshots, design docs, user docs, etc. as necessary. Consider which reviewers may be outside of your team and how much of the feature/area should be explained more.]

Testing status

[Explanation of what’s been tested, how it was tested, and changes to existing or new automation tests. Testing can include manual testing by self and/or QA. Specify test plans; Rarely acceptable to have no testing.]

Technical / Halo risk

[Overall product level assessment of the risk of the changes using the following criteria:

Tech Risk (not Tech Correctness, which is deferred to the reviewers)

  • 0 could be just zero impact changes, removals but no logic changes
  • 1 low impact, simple logic changes
  • 2 is anything between 1 and 3
  • 3 are extremely likely to introduce bugs

Halo Risk (Externality risk)

  • 0 local change with no risk to other areas
  • 1 neighbors could be affected
  • 2 anything between 1 and 3
  • 3 things might break everywhere]

Comments to reviewers

[Per person info for what to focus on or historical info for a new reviewer to understand who may have previously reviewed and what their coverage was. Provide context.]

mtschoen-unity and others added 30 commits July 2, 2019 14:24
…ule connects last;

This fixes a bug where it tries to deserialize preferences before the tool module has set up linked tools, causing errors in deserialization
AdaptivePositionModule was getting the wrong camera because the VR Camera doesn't exist when modules are loaded
# Conflicts:
#	Runtime/Fonts/Roboto/Roboto-Light SDF.lfs.asset
#	Runtime/Fonts/Roboto/Roboto-Medium SDF.lfs.asset
#	Runtime/Fonts/Roboto/Roboto-Regular SDF.lfs.asset
#	Runtime/libs/UnityOctree
#	Runtime/libs/VRLineRenderer
…ity-injection

# Conflicts:
#	Editor/Unity.Labs.EditorXR.Editor.asmdef
#	Runtime/Scripts/Core/EditorVR.cs
#	Runtime/Scripts/Core/EditorXRDirectSelectionModule.cs
#	Runtime/Scripts/Core/EditorXRMenuModule.cs
#	Runtime/Scripts/Core/EditorXRMiniWorldModule.cs
#	Runtime/Scripts/Core/EditorXRRayModule.cs
#	Runtime/Scripts/Core/EditorXRToolModule.cs
#	Runtime/Scripts/Core/EditorXRToolsMenuModule.cs
#	Runtime/Scripts/Core/EditorXRUIModule.cs
#	Runtime/Scripts/Modules/ActionsModule.cs
#	Runtime/Scripts/Modules/AdaptivePositionModule/AdaptivePositionModule.cs
#	Runtime/Scripts/Modules/DeviceInputModule.cs
#	Runtime/Scripts/Modules/GazeDivergenceModule/GazeDivergenceModule.cs
#	Runtime/Scripts/Modules/WorkspaceModule.cs
#	Runtime/Workspaces/PolyWorkspace/Scripts/PolyGridAsset.cs
# Conflicts:
#	Runtime/Scripts/Core/Interfaces/IDelayedInitializationModule.cs
#	Runtime/Scripts/Core/Interfaces/IDelayedInitializationModule.cs.meta
#	Runtime/Scripts/Core/Interfaces/IInitializableModule.cs
#	Runtime/Scripts/Core/Interfaces/IInitializableModule.cs.meta
#	Runtime/libs/UnityOctree
#	Runtime/libs/VRLineRenderer
#	Scripts/Core/Interfaces/IInitializableModule.cs
#	Scripts/Core/Interfaces/IInitializableModule.cs.meta
…ity-injection

# Conflicts:
#	Runtime/Scripts/Core/EditorXRDirectSelectionModule.cs
#	Runtime/Scripts/Core/EditorXRInterfacesModule.cs
#	Runtime/Scripts/Core/EditorXRMenuModule.cs
#	Runtime/Scripts/Core/EditorXRRayModule.cs
#	Runtime/Scripts/Core/EditorXRToolModule.cs
#	Runtime/Scripts/Core/EditorXRUIModule.cs
#	Runtime/Scripts/Core/EditorXRViewerModule.cs
#	Runtime/Scripts/Modules/AdaptivePositionModule/AdaptivePositionModule.cs
#	Runtime/Scripts/Modules/DeviceInputModule.cs
#	Runtime/Scripts/Modules/FeedbackModule/FeedbackModule.cs
#	Runtime/Scripts/Modules/GazeDivergenceModule/GazeDivergenceModule.cs
#	Runtime/Scripts/Modules/IntersectionModule/IntersectionModule.cs
#	Runtime/Scripts/Modules/SnappingModule/SnappingModule.cs
#	Runtime/Scripts/Modules/SpatialHashModule.cs
#	Runtime/Scripts/Modules/SpatialHintModule/SpatialHintModule.cs
#	Runtime/Scripts/Modules/TooltipModule/TooltipModule.cs
#	Runtime/Workspaces/PolyWorkspace/Scripts/PolyModule.cs
Fix build issues in PolyGridAsset
… in Editor UI;

Fix FI-related issues with MultipleRayInputModule refactor
# Conflicts:
#	Runtime/libs/UnityOctree
#	Runtime/libs/VRLineRenderer
Fix tiny undo menu;
Save auto-upgrade changes to font assets
mtschoen-unity and others added 30 commits August 21, 2020 03:15
Update version to 0.4.10-preview for future development
Update changelog;
Add dependencies to readme;
Update version for known issues in documentation
List Multiselect interface implementation
Update changelog
Make test types not public
Add a security policy document outlining supported versions and vulnerability reporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants