-
Notifications
You must be signed in to change notification settings - Fork 166
Patch 1 #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oginternational
wants to merge
1,976
commits into
Unity-Technologies:bugfixes/schoen/always-undo
Choose a base branch
from
Oginternational:patch-1
base: bugfixes/schoen/always-undo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch 1 #588
Oginternational
wants to merge
1,976
commits into
Unity-Technologies:bugfixes/schoen/always-undo
from
Oginternational:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule connects last; This fixes a bug where it tries to deserialize preferences before the tool module has set up linked tools, causing errors in deserialization
List View Integration
AdaptivePositionModule was getting the wrong camera because the VR Camera doesn't exist when modules are loaded
# Conflicts: # Runtime/Fonts/Roboto/Roboto-Light SDF.lfs.asset # Runtime/Fonts/Roboto/Roboto-Medium SDF.lfs.asset # Runtime/Fonts/Roboto/Roboto-Regular SDF.lfs.asset # Runtime/libs/UnityOctree # Runtime/libs/VRLineRenderer
…ity-injection # Conflicts: # Editor/Unity.Labs.EditorXR.Editor.asmdef # Runtime/Scripts/Core/EditorVR.cs # Runtime/Scripts/Core/EditorXRDirectSelectionModule.cs # Runtime/Scripts/Core/EditorXRMenuModule.cs # Runtime/Scripts/Core/EditorXRMiniWorldModule.cs # Runtime/Scripts/Core/EditorXRRayModule.cs # Runtime/Scripts/Core/EditorXRToolModule.cs # Runtime/Scripts/Core/EditorXRToolsMenuModule.cs # Runtime/Scripts/Core/EditorXRUIModule.cs # Runtime/Scripts/Modules/ActionsModule.cs # Runtime/Scripts/Modules/AdaptivePositionModule/AdaptivePositionModule.cs # Runtime/Scripts/Modules/DeviceInputModule.cs # Runtime/Scripts/Modules/GazeDivergenceModule/GazeDivergenceModule.cs # Runtime/Scripts/Modules/WorkspaceModule.cs # Runtime/Workspaces/PolyWorkspace/Scripts/PolyGridAsset.cs
# Conflicts: # Runtime/Scripts/Core/Interfaces/IDelayedInitializationModule.cs # Runtime/Scripts/Core/Interfaces/IDelayedInitializationModule.cs.meta # Runtime/Scripts/Core/Interfaces/IInitializableModule.cs # Runtime/Scripts/Core/Interfaces/IInitializableModule.cs.meta # Runtime/libs/UnityOctree # Runtime/libs/VRLineRenderer # Scripts/Core/Interfaces/IInitializableModule.cs # Scripts/Core/Interfaces/IInitializableModule.cs.meta
…ity-injection # Conflicts: # Runtime/Scripts/Core/EditorXRDirectSelectionModule.cs # Runtime/Scripts/Core/EditorXRInterfacesModule.cs # Runtime/Scripts/Core/EditorXRMenuModule.cs # Runtime/Scripts/Core/EditorXRRayModule.cs # Runtime/Scripts/Core/EditorXRToolModule.cs # Runtime/Scripts/Core/EditorXRUIModule.cs # Runtime/Scripts/Core/EditorXRViewerModule.cs # Runtime/Scripts/Modules/AdaptivePositionModule/AdaptivePositionModule.cs # Runtime/Scripts/Modules/DeviceInputModule.cs # Runtime/Scripts/Modules/FeedbackModule/FeedbackModule.cs # Runtime/Scripts/Modules/GazeDivergenceModule/GazeDivergenceModule.cs # Runtime/Scripts/Modules/IntersectionModule/IntersectionModule.cs # Runtime/Scripts/Modules/SnappingModule/SnappingModule.cs # Runtime/Scripts/Modules/SpatialHashModule.cs # Runtime/Scripts/Modules/SpatialHintModule/SpatialHintModule.cs # Runtime/Scripts/Modules/TooltipModule/TooltipModule.cs # Runtime/Workspaces/PolyWorkspace/Scripts/PolyModule.cs
… into companion-misc
Fix build issues in PolyGridAsset
… in Editor UI; Fix FI-related issues with MultipleRayInputModule refactor
Module loader Part 1
# Conflicts: # Runtime/libs/UnityOctree # Runtime/libs/VRLineRenderer
Make EditorXR a Package
…onality-injection
Fix tiny undo menu; Save auto-upgrade changes to font assets
Update version to 0.4.10-preview for future development
… fallback not using the right base class
…to set up right after a domain reload
Update changelog; Add dependencies to readme; Update version for known issues in documentation
…_test_versions add editor test version
List Multiselect interface implementation
Update changelog
Make test types not public
Add a security policy document outlining supported versions and vulnerability reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
[Description of the feature/changes. Links to screenshots, design docs, user docs, etc. as necessary. Consider which reviewers may be outside of your team and how much of the feature/area should be explained more.]
Testing status
[Explanation of what’s been tested, how it was tested, and changes to existing or new automation tests. Testing can include manual testing by self and/or QA. Specify test plans; Rarely acceptable to have no testing.]
Technical / Halo risk
[Overall product level assessment of the risk of the changes using the following criteria:
Tech Risk (not Tech Correctness, which is deferred to the reviewers)
Halo Risk (Externality risk)
Comments to reviewers
[Per person info for what to focus on or historical info for a new reviewer to understand who may have previously reviewed and what their coverage was. Provide context.]