Add ShitGiftHook hook on ethereum#580
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Review: hooks/ethereum/0x0f7ff748f58d16876ba71783f3a7cf2cf3f2c040.json
Contract: ShitGiftHook — verified source on Ethereum mainnet.
Address Flags
0x...c040 → lowest 14 bits = 0x0040 → only bit 6 set = afterSwap. Matches JSON and confirmed by getHookPermissions() in source.
Flags ✓
All 14 flags correct. Only afterSwap: true.
Properties ✓
- dynamicFee: false —
afterSwapreturns(selector, 0); noupdateDynamicLPFee()call anywhere. - upgradeable: false — no proxy pattern, no delegatecall, no mutable implementation pointer.
source_meta.jsonconfirmsproxy: false. - requiresCustomSwapData: false —
hookDatais ignored (bytes calldata /* hookData */). Swaps proceed normally without it. - vanillaSwap: false — correct.
afterSwapcallsIERC20(art).safeTransfer(origin, 1 ether), i.e. it transfers tokens insideafterSwap, so the swap does not behave identically to a standard v4 pool. - swapAccess: "none" — correct. No
beforeSwapflag. The pool-key matching inafterSwapis pool identity verification, not swap access control.
Metadata ✓
- chainId: 1 matches
chains.jsonforethereum. - name: "ShitGiftHook" matches
contractNameinsource_meta.jsonand the contract definition. No promotional or endorsement language. - verifiedSource: true matches
source_meta.json. - description accurately reflects the Solidity logic: 42069 SHIT minimum (
MIN_BUY = 42069 ether), 1% RNG (DROP_CHANCE_BPS = 100), 1 ether art token transfer totx.origin, 24h cooldown (DROP_COOLDOWN = 1 days), CEI ordering explicitly enforced in code, factory-gated deposits. No audit claims or marketing language.
All fields verified against on-chain source. No issues found.
|
Please close — superseded by #582. The hook at 0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used (no pool initialized; zero on-chain interactions since deployment). It was abandoned in favor of a Future-RANDAO queue-model redesign. The live production hook for this project is deployed at 0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (verified on Etherscan, submitted in #581 / PR #582). Issue #579 has been closed as superseded. Merging this PR would register a stale, never-to-be-used entry. Please close in favor of #582. |
marktoda
left a comment
There was a problem hiding this comment.
Bot review verified. ShitGiftHook at 0x0f7f... (afterSwap only, bit 6, bitmask 0x40). Description at 455/500 chars — close to limit but compliant. Properties consistent with source. LGTM.
This reverts commit 1d423c1 (PR #580). The submitter (@dogeshitmeme, who opened issue #579) requested PR #580 be closed before it was merged: the hook at 0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used (no pool initialized, zero on-chain interactions) and was abandoned in favor of a Future-RANDAO queue-model redesign deployed at 0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (PR #582, already on main). Issue #579 was closed by the submitter as superseded. The close-request comments arrived after the bot's APPROVED review and were not surfaced to the triage fast-path before merge. regenerate.yml will rebuild hooklist.json on merge to drop the stale entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This reverts commit 1d423c1 (PR #580). The submitter (@dogeshitmeme, who opened issue #579) requested PR #580 be closed before it was merged: the hook at 0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used (no pool initialized, zero on-chain interactions) and was abandoned in favor of a Future-RANDAO queue-model redesign deployed at 0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (PR #582, already on main). Issue #579 was closed by the submitter as superseded. The close-request comments arrived after the bot's APPROVED review and were not surfaced to the triage fast-path before merge. regenerate.yml will rebuild hooklist.json on merge to drop the stale entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Uniswap V4 afterSwap hook for the ShitVerse meme ecosystem. On any qualifying buy (≥ 42069 SHIT) of the canonical ETH/SHIT 1% pool, rolls a 1% RNG and on win transfers 1 ether of a randomly-picked community-deposited 'art' token (ERC-20/ERC-1155 dual-surface DualToken) to tx.origin. Per-origin 24h cooldown; CEI ordering with all state writes committed before the external transfer. Pool membership gated by ShitVerseFactory.isValidToken at deposit time.
Flags
Properties
Warnings
None
Closes #579