fix(l10n): Use resource strings for default dialog string resources #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary API dependency on Kotlin stdlib.
The user might register with a distributor, and then delete the distributor app. If that happens the user is not prompted if there are no distributors, and re-registration does not happen. Fix this by checking the ack'ed distributor is still in the list of installed distributors.
Previous code ignored the dialog's default layout and set its own textview. I think this was so a LinkMovementMethod could be set on the message. This meant the view didn't follow normal Android dialog dimensions (e.g., padding, margins, text layout), and looked out of place. Fix this. Use the normal AlertDialog message. Set an onShowListener that sets the LinkMovementMethod when the dialog is shown.
The strings used in default dialogs were hardcoded. This meant they couldn't be translated, or use the default platform strings (e.g., android.R.string.ok). Fix that. Convert `RegistrationDialogContent`, `NoDistributorDialog`, and `ChooseDialog` to interfaces, and provide implementations of those interfaces that
Member
|
Thanks again for your contribution. This introduces breaking changes, so it can't be merged like it is |
Contributor
Author
|
Do you want me to add a commit to the PR that bumps the release version to 3.0.0? |
Member
|
I think it is better to keep that PR pending, we will update the specification in the coming months to embrace webpush. This will be an appropriate moment for a major release |
Member
|
The other option is to keep the object with a warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strings used in default dialogs were hardcoded. This meant they
couldn't be translated, or use the default platform strings (e.g.,
android.R.string.ok).
Fix that. Convert
RegistrationDialogContent,NoDistributorDialog,and
ChooseDialogto interfaces, and provide implementations of thoseinterfaces that use the default strings.