fix: endExchange not being sent #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test:uipath-langchain
There was a problem hiding this comment.
Pull request overview
This pull request fixes a race condition where the "endExchange" event was not being sent before process termination. The issue occurred because socket.io's send() and disconnect() operations are asynchronous background tasks, allowing the process to exit before pending messages were transmitted.
Changes:
- Added
await self._client.wait()afterdisconnect()to ensure all pending socket.io operations complete before cleanup - Added explanatory comment documenting the race condition and fix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristipufu
force-pushed
the
fix/end-exchange-not-sent
branch
from
5b6c26f to
91a52dd
Compare
cristipufu
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.io send and disconnect are both background operations even when you await on the api calls. This allows the final "endExchange" event to go unsent if the process exits too quickly when the agent terminates. The fix is to wait for the disconnect to complete.