Skip to content

feat(apollo-vertex): data table overhaul with MRS upstream improvements#411

Open
creilly11235 wants to merge 1 commit intomainfrom
data-table
Open

feat(apollo-vertex): data table overhaul with MRS upstream improvements#411
creilly11235 wants to merge 1 commit intomainfrom
data-table

Conversation

@creilly11235
Copy link
Collaborator

@creilly11235 creilly11235 commented Mar 27, 2026

Summary

  • Upstream refined data-table UX from vertical-medical-mrs back to the Apollo Vertex registry
  • Simplified column header (click-to-sort replaces dropdown), scroll shadows, cell truncation tooltips, improved pagination/search/skeleton/toolbar
  • Glass container styling, new props (getRowClassName, skeletonColumnWidths, noResultsMessage as ReactNode, overflowVisible column meta)
  • New DataTableRow/DataTableCell exports for custom compositions
  • i18n defaultValue fallbacks for standalone use without Shell
  • Demo updated with status badges (secondary + status variants), sentence case

🤖 Generated with Claude Code

@creilly11235 creilly11235 requested a review from a team as a code owner March 27, 2026 02:15
@creilly11235 creilly11235 requested review from frankkluijtmans and ruudandriessen and removed request for a team March 27, 2026 02:15
@github-actions
Copy link

github-actions bot commented Mar 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Mar 26, 2026, 07:57:26 PM
apollo-landing 🟢 Ready Preview, Logs Mar 26, 2026, 07:54:52 PM
apollo-ui-react 🟢 Ready Preview, Logs Mar 26, 2026, 07:56:23 PM
apollo-vertex 🟢 Ready Preview, Logs Mar 26, 2026, 07:55:53 PM
apollo-wind 🟢 Ready Preview, Logs Mar 26, 2026, 07:55:01 PM

@KokoMilev KokoMilev enabled auto-merge (rebase) March 27, 2026 02:15
@github-actions
Copy link

github-actions bot commented Mar 27, 2026

Dependency License Review

  • ✅ 1923 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1688
ISC 89
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 27, 2026
View reviewed changes
apps/apollo-vertex/registry/data-table/data-table-column-header.tsx
@@ -1,31 +1,20 @@
"use client";
"use no memo";

Check warning

Code scanning / CodeQL

Unknown directive Warning

Unknown directive: 'use no memo'.

Copilot Autofix

AI about 8 hours ago

In general, to fix an unknown directive you either (1) correct the string to a known, intended directive, or (2) remove it if no such directive exists or is needed. Since "use no memo" is not a standard directive and there is no obvious corresponding valid directive (React does not define "use no memo"), the safest fix that preserves existing functionality is to remove this stray directive line entirely, leaving only the valid "use client"; directive.

Concretely, in apps/apollo-vertex/registry/data-table/data-table-column-header.tsx, delete line 2 containing "use no memo"; and leave the rest of the file unchanged. No imports, methods, or additional definitions are required, because we are only removing a no-op string literal that is not referenced anywhere else. This avoids changing runtime behavior while resolving the CodeQL warning and preventing future confusion for maintainers.

Suggested changeset 1
apps/apollo-vertex/registry/data-table/data-table-column-header.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/apollo-vertex/registry/data-table/data-table-column-header.tsx b/apps/apollo-vertex/registry/data-table/data-table-column-header.tsx
--- a/apps/apollo-vertex/registry/data-table/data-table-column-header.tsx
+++ b/apps/apollo-vertex/registry/data-table/data-table-column-header.tsx
@@ -1,5 +1,4 @@
 "use client";
-"use no memo";
 
 import type { Column, SortDirection } from "@tanstack/react-table";
 import { ArrowDownIcon, ArrowUpIcon } from "lucide-react";
EOF
@@ -1,5 +1,4 @@
"use client";
"use no memo";

import type { Column, SortDirection } from "@tanstack/react-table";
import { ArrowDownIcon, ArrowUpIcon } from "lucide-react";
Copilot is powered by AI and may make mistakes. Always verify output.
github-code-quality[bot]
github-code-quality bot found potential problems Mar 27, 2026
View reviewed changes
apps/apollo-vertex/registry/data-table/data-table-column-header.tsx
@@ -1,31 +1,20 @@
"use client";
"use no memo";
@creilly11235 @claude
feat(apollo-vertex): overhaul data-table with MRS upstream improvements
8541d65 
Upstream refined data-table UX from vertical-medical-mrs back to the
Apollo Vertex registry. Key changes:

- Simplified column header: click-to-sort replaces dropdown menu
- Scroll shadows: framer-motion gradient overlays on horizontal overflow
- Cell truncation tooltips: native title shown only when content clips
- Pagination: [10,25,50,100] + "All", filtered sizes, flex-wrap layout
- Search: icon inside input, responsive width, borderless
- View options: icon-only button with tooltip
- Skeleton: per-column width customization with cycling defaults
- Toolbar: flex-wrap with restructured layout
- Glass container: inline frosted backdrop-blur styling
- New props: getRowClassName, skeletonColumnWidths, noResultsMessage
  as ReactNode, overflowVisible column meta
- New exports: DataTableRow, DataTableCell for custom compositions
- Base table: opt-in row hover, text-sm on TableHead
- i18n: defaultValue fallbacks for standalone use without Shell
- Demo: status badges with secondary+status variants, sentence case

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruudandriessen ruudandriessen Awaiting requested review from ruudandriessen ruudandriessen is a code owner automatically assigned from UiPath/team-frontendhoven

@frankkluijtmans frankkluijtmans Awaiting requested review from frankkluijtmans frankkluijtmans is a code owner automatically assigned from UiPath/team-frontendhoven

1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@creilly11235