feat(apollo-vertex): add dismissible prop to Alert#407
Open
creilly11235 wants to merge 1 commit intomainfrom
Open
feat(apollo-vertex): add dismissible prop to Alert#407creilly11235 wants to merge 1 commit intomainfrom
creilly11235 wants to merge 1 commit intomainfrom
Conversation
Adds first-class dismiss support to the Alert registry component with a `dismissible` boolean prop, `onDismiss` callback, internal visibility state, and automatic right padding for the close button. Replaces the external DismissibleAlert wrapper in notification-examples with the built-in prop. Updates docs with usage example and props table entries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
creilly11235
requested review from
angeloaltamiranom and
ruudandriessen
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dismissibleboolean prop andonDismisscallback to the Alert registry component, replacing the externalDismissibleAlertwrapper pattern used in notification-examplespr-10padding, internal visibility state,aria-label="Dismiss", andstopPropagationto avoid bubbling to parent click handlers"use client"sinceuseStateis now used for visibilityDismissibleAlertwrapper in favor of the built-in prop🤖 Generated with Claude Code