add tooltip showing grade and RMP data#112
Open
jakobqnen wants to merge 3 commits into
Open
Conversation
Author
|
added an icon next to the professor name in the column added by Skedge. When a name or the icon is hovered over, a tooltip appears, displaying grade and RMP data for that combo. The tooltip comes from the icon and wraps below the professor name being hovered on. Skedge currently doesn't use the professor alias table from Trends, so data is not available for some professors. When data is not available, either [No grades data] or [No RMP data] is shown in the tooltip instead of the data. The functions for getting Grades and RMP data were moved from app/index.tsx to a new file data/fetchGradesData.tsx . content.ts sends a message to the background/index.ts script to run the functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.