Skip to content

Conversation

@dfkapraun
Copy link
Collaborator

@dfkapraun dfkapraun commented Jan 21, 2026

  • Fix issue with spaces in path names by reintroducing 'utils::shortPathName()' into 'fixPath.R'.
  • Update docstrings for 'updateParms()' and 'updateY0()' in 'MCSim_model.R' to better reflect functionality of those methods.
  • Update version number in 'DESCRIPTION' in preparation for the next release.

…pdated docstrings in 'MCSim_model.R', and updated version number in 'DESCRIPTION'.
@dfkapraun dfkapraun requested review from Copilot and tjzurlin January 21, 2026 21:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses path handling issues on Windows, improves documentation clarity, and prepares for a new release. The changes focus on fixing a bug with spaces in Windows paths by reintroducing path normalization logic, updating method documentation to accurately describe their reset-then-update behavior, and bumping the version number.

Changes:

  • Fixed Windows path handling to support spaces by converting to short path names
  • Corrected typo in comment ("generate" → "generated")
  • Enhanced docstrings for updateParms() and updateY0() to clarify that they reset to defaults before applying updates
  • Bumped version from 1.1.9000 to 1.2

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
R/fixPath.R Adds Windows-specific path normalization using shortPathName() and fixes typo in comment
R/MCSim_model.R Updates docstrings to clarify reset-then-update behavior of parameter and state update methods
man/Model-class.Rd Updates documentation to match improved docstrings in source code
DESCRIPTION Updates package version to 1.2 for release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dfkapraun dfkapraun merged commit 5e74f06 into main Jan 22, 2026
3 checks passed
@dfkapraun dfkapraun deleted the fixpath branch January 22, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants