Fix llvm20 compile issue in tuple.hpp#872
Merged
AzothAmmo merged 1 commit intoUSCiLab:masterfrom Mar 6, 2026
Merged
Conversation
jarzec
approved these changes
Feb 23, 2026
Contributor
jarzec
left a comment
jarzec
left a comment
There was a problem hiding this comment.
LGTM
Explicit template specialization seems to be slightly safer and expresses intent better.
minyez
added a commit
to minyez/LibRPA
that referenced
this pull request
Apr 23, 2026
Replace 835 with the merged request 872 for llvm-base compiler. See USCiLab/cereal#872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a compilation issue with my library using cereal when I tried to compile it with clang++-20. GCC is still working fine, but it is not accepted by clang++-20. This PR introduces a minor change that fixes the issue. AFAIK, GCC is accepting this because of the bug.
llvm/llvm-project#94194