cda-37 Store blobs in object-store #1519
Conversation
|
still lots to cleanup and reorganize |
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Seems reasonable so far.
rma-rripken
force-pushed
the
feature/cda-37-s3_blob_and_clob
branch
from
4da44e9 to
d02ccfe
Compare
…nd Content-Length headers instead.
…reManagerProvider.
|
I think I've implemented all the blob parts. Would need to follow up with a similar clob dao that handles text encoding. |
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Overall looks good. A few nitpicks and probably at least one just misunderstanding of togglz on my part I need clarified.
| return new BlobDao(dsl); | ||
| } | ||
|
|
||
| private boolean isObjectStorageEnabled() { |
There was a problem hiding this comment.
Shouldn't this just use the CdaFeatures thing?
cwms-data-api/src/test/java/cwms/cda/api/BinaryTimeSeriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static void setupMinioResources() { |
There was a problem hiding this comment.
- This should just be in the Cda Setup extension and can just be started whenever, eventually it'll be the only option and it doesn't really get in the way just being on.
- https://testcontainers.com/modules/minio/ (favor the testcontainer helper modules unless you have reason not to, we do our own for CWMS to make the CWMS setup easier to handle.)
There was a problem hiding this comment.
As suggested in #2 - switching to the testcontainer module makes it simpler.
I'm not sure I understand the suggestion in #1 - What does "Cda Setup" reference? I think you are saying to move the minio-container out of this test and put it somewhere that runs all the time.
Would the minio-container be its own @ExtendWith callback that gets added to DataApiTestIT sort of like KeyCloakExtension ?
No description provided.