refactor: do not create admin user when no necessary #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| my $rvd_back = Ravada->new(%CONFIG); | ||
| $rvd_back->_install(); | ||
| my %install_args; | ||
| $install_args{add_user_admin} = 0 if $ADD_USER; |
There was a problem hiding this comment.
The condition here should also include other user-adding options for consistency. Currently, only $ADD_USER triggers the suppression of admin user creation, but there are other user-adding options ($ADD_USER_LDAP, $ADD_USER_FILE, $ADD_USER_GROUP) that arguably should also suppress automatic admin user creation. Consider whether these other user-adding operations should also set add_user_admin to 0.
Suggested change
| $install_args{add_user_admin} = 0 if $ADD_USER; | |
| $install_args{add_user_admin} = 0 if $ADD_USER || $ADD_USER_LDAP || $ADD_USER_FILE || $ADD_USER_GROUP; |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling rvd_back with create user option, disable auto-creation
issue #2267