Fix/gsteenkamp custom bond #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Reinis-FRP
reviewed
Sep 18, 2025
| "ID is managedRequestId, ie. the hash of requester, identifier, ancillaryData" | ||
| id: ID! | ||
|
|
||
| managedRequestId: String! |
Contributor
There was a problem hiding this comment.
why do we need this, isn't it the same as it for CustomLiveness?
Contributor
Author
There was a problem hiding this comment.
oh true, we can probably remove it.
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
gsteenkamp89
force-pushed
the
fix/gsteenkamp-custom-bond
branch
from
3bd6928 to
e1f62f5
Compare
Reinis-FRP
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes UMA-2945
Fix Custom Bond Currency Matching Logic
Problem
Custom bonds were not being properly matched to price requests based on currency. The system was incorrectly applying custom bonds regardless of currency mismatch.
Solution
Key Changes
handleCustomBondSetto usecreateCustomBondIdFromEventfor entity ID generationgetCustomBondto only find custom bonds with matching currenciesTechnical Details
Custom bond IDs are now generated by hashing:
requester + identifier + ancillaryData + currency. This ensures that custom bonds set for different currencies have different IDs, even with identical other parameters, preventing cross-currency bond application.