fix(ui5-illustrated-message): remove custom --sap parameter declarations#13471
Open
dobrinyonkov wants to merge 2 commits intomainfrom
Open
fix(ui5-illustrated-message): remove custom --sap parameter declarations#13471dobrinyonkov wants to merge 2 commits intomainfrom
dobrinyonkov wants to merge 2 commits intomainfrom
Conversation
Remove all custom --sapIllus_* CSS variable declarations from the IllustratedMessage-parameters.css file and replace their usages in IllustratedMessage.css with the original SAP theming base content variables (--sapContent_Illustrative_Color*) they were aliasing. This eliminates an unnecessary layer of indirection where custom variables simply mapped to existing theming variables without adding any value. Fixes #13056
The IllustratedMessage-parameters.css file is now empty after removing the custom --sap variable declarations. Remove the file and all its imports from the theme parameters-bundle.css files.
Collaborator
|
🚀 Deployed on https://pr-13471--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sapIllus_*CSS variable declarations fromIllustratedMessage-parameters.cssvar(--sapIllus_*)usages inIllustratedMessage.csswith the original SAP theming base content variables (--sapContent_Illustrative_Color*) they were aliasing--sapIllus_NoColor,--sapIllus_PatternShadow,--sapIllus_PatternHighlight), inlined the literal values (none,url(#...)) directlyThis eliminates an unnecessary layer of indirection where custom CSS variables simply mapped to existing theming variables without adding any value.
Fixes #13056
Test plan