fix(ui5-li): remove redundant "Is Active" accessibility announcement#13338
Open
plamenivanov91 wants to merge 1 commit intomainfrom
Open
fix(ui5-li): remove redundant "Is Active" accessibility announcement#13338plamenivanov91 wants to merge 1 commit intomainfrom
plamenivanov91 wants to merge 1 commit intomainfrom
Conversation
The type="Active" property indicates the item's interactive behavior (clickable), not its state. Screen readers were repeatedly announcing "Is Active" on every list item with type="Active", which was confusing and non-specific. Selected/not-selected state is already properly announced separately via aria-selected and ariaSelectedText in aria-describedby. Changes: - Remove LIST_ITEM_ACTIVE from ariaLabelledByText getter - Remove unused LIST_ITEM_ACTIVE import from ListItem.ts - Update accessibility test to verify "Is Active" is not announced - Remove LIST_ITEM_ACTIVE from default messagebundle.properties Fixes: #13265
Collaborator
|
🚀 Deployed on https://pr-13338--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type="Active" property indicates the item's interactive behavior (clickable), not its state. Screen readers were repeatedly announcing "Is Active" on every list item with type="Active", which was confusing and non-specific.
Selected/not-selected state is already properly announced separately via aria-selected and ariaSelectedText in aria-describedby.
Changes:
Fixes: #13265