fix(ui5-dynamic-page): hide pin button on mobile devices#13335
Merged
NakataCode merged 2 commits intomainfrom Mar 26, 2026
Merged
fix(ui5-dynamic-page): hide pin button on mobile devices#13335NakataCode merged 2 commits intomainfrom
NakataCode merged 2 commits intomainfrom
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13335--ui5-webcomponents.netlify.app |
Contributor
Code reviewFound 1 issue:
Wrong selector in test: webcomponents/packages/fiori/cypress/specs/DynamicPage.mobile.cy.tsx Lines 201 to 203 in 78478c1 Actual class in template: webcomponents/packages/fiori/src/DynamicPageHeaderActionsTemplate.tsx Lines 20 to 22 in 78478c1 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
kgogov
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin/unpin button is now automatically hidden on mobile devices in accordance with SAP Fiori guidelines, which state that the Pin Header action should not be provided on small screens as the pinned header would take up too much screen real estate.
Fixes #13320