[RFC] feat(ui5-li): add semantic click event to ListItemBase#13315
Open
[RFC] feat(ui5-li): add semantic click event to ListItemBase#13315
Conversation
Fire a public CustomEvent("click") with { item, originalEvent } detail
from ListItemBase.fireItemPress(), covering mouse click, Enter, and
Space activation. Native click from shadow DOM <li> is stopped via
stopPropagation to prevent duplicate events reaching consumers.
All components extending ListItemBase (ListItemStandard, MenuItem,
TreeItem, NotificationListItem, etc.) inherit this behavior.
Resolves #13304
488384b to
46c7b2a
Compare
Collaborator
|
🚀 Deployed on https://pr-13315--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickCustomEvent toListItemBase, enabling framework consumers (React, Angular, Vue) to attachonClickhandlers directly on list items (<ListItemStandard onClick={...}>) instead of relying on the parent container'sitem-clickeventitem(the ListItemBase instance) andoriginalEvent(the underlying mouse/keyboard event), matching the Button's semantic click pattern<li>is stopped viastopPropagation()to prevent duplicate events reaching consumersResolves #13304
Changes
packages/main/src/ListItemBase.ts@event("click", { bubbles: true })decoratorListItemBaseClickEventDetailtype withitemandoriginalEventfireItemPress()now firesfireDecoratorEvent("click", { item, originalEvent })alongside existing_press_onclick()callse.stopPropagation()beforefireItemPress()to suppress native click from shadow DOMTest plan
List.cy.tsx— 5 new tests (click, Enter, Space, disabled, backward compat with item-click)Menu.cy.tsx— 3 new tests (click, Enter, backward compat with item-click)Tree.cy.tsx— 5 new tests (click, Enter, Space, disabled, backward compat with item-click)"click"(not"ui5-click") and assertcalledOnceto verify no duplicate native+semantic events