Skip to content

fix(ui5-dynamic-page): handle header-snapped attribute initialization #13030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kgogov wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −2
Open

fix(ui5-dynamic-page): handle header-snapped attribute initialization #13030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/fiori/cypress/specs/DynamicPage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,35 @@ describe("DynamicPage", () => {
.should("have.prop", "headerPinned", false);
});

it("renders correctly with initial header-snapped attribute", () => {
cy.mount(
<DynamicPage headerSnapped={true} style={{ height: "600px" }}>
<DynamicPageTitle slot="titleArea">
<div slot="heading">Page Title</div>
<div slot="snappedHeading">Snapped Title</div>
</DynamicPageTitle>
<DynamicPageHeader slot="headerArea">
<div>Header Content</div>
</DynamicPageHeader>
<div style={{ height: "1000px" }}>
Page content with enough height to enable scrolling
</div>
</DynamicPage>
);

cy.get("[ui5-dynamic-page]")
.should("have.prop", "headerSnapped", true);

cy.get("[ui5-dynamic-page-title]")
.should("have.prop", "snapped", true);

cy.get("[ui5-dynamic-page-header]")
.should("have.prop", "_snapped", true);

cy.get("[slot='snappedHeading']")
.should("be.visible");
});

it("toggles the header-snapped state with 'headerSnapped' property", () => {
cy.mount(
<DynamicPage style={{ height: "600px" }}>
Expand Down
12 changes: 10 additions & 2 deletions packages/fiori/src/DynamicPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,17 @@ class DynamicPage extends UI5Element {
*/
@property({ type: Boolean })
set headerSnapped(snapped: boolean) {
if (snapped !== this._headerSnapped) {
this._toggleHeader();
if (snapped === this._headerSnapped) {
return;
}

if (!this.scrollContainer) {
this._headerSnapped = snapped;
this.showHeaderInStickArea = snapped;
return;
}

this._toggleHeader();
}

snapOnScroll() {
Expand Down
Loading