Skip to content

fix(OpenUI5Support): override default [popover] padding #13019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-todorova wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix(OpenUI5Support): override default [popover] padding #13019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/base/src/css/OpenUI5PopupStyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
border: none;
overflow: visible;
margin: 0;
padding: 0;
Copy link
Contributor

@ilhan007 ilhan007 Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clear the left/right paddings (reported in the related issue), but there is a chance to also overwrite/reset the sap.m.Dialog's top and bottom paddings. Did you verify this? If yes - then it's good to go.

Copy link
Contributor Author

@s-todorova s-todorova Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local page for OpenUi5Support - seemed ok.

Copy link
Contributor

@ilhan007 ilhan007 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine verifying it on the reproducible environment (because the release + consumption cycle is a long process) but this is up to you - I am fine with the change itself.

Copy link
Member

@TeodorTaushanov TeodorTaushanov Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will override the bottom and top paddings of the sap.m.Dialog.

The issue is visible if you add footer to some dialog in the DialogAndOpenUI5Dialog.html like:

new Dialog("openUI5DialogWithButtons", {
					buttons: [
						new Button({
							text: "Close",
							press: function () {
								this.getParent().close();
							}
						})
					],

This will also override the default paddings of the .sapMValueStateMessage and .sapMMessageToast classes. Probably and some others.

I think it will be better to fix the issue in the OpenUI5 project.

Add to

  • .sapMDialog - padding-inline: 0;
  • .sapMPopover - padding: 0;
  • .sapMLightBox - padding: 0;
  • .sapUiHintContainer - padding: 0;

}

.sapUiBLy[popover] {
Expand Down
Loading