refactor: Support of referencing legacy middlewares in UI5 CLI middleware configuration#1367
Open
d3xter666 wants to merge 17 commits intofeat/incremental-build-4from
Open
refactor: Support of referencing legacy middlewares in UI5 CLI middleware configuration#1367d3xter666 wants to merge 17 commits intofeat/incremental-build-4from
d3xter666 wants to merge 17 commits intofeat/incremental-build-4from
Conversation
RandomByte
force-pushed
the
feat/incremental-build-4
branch
from
e1d781f to
ab65f27
Compare
Build tests: add getRootPath stub and cacheDir to expected args to match the new cache directory parameter in graph.build(). Serve tests: adapt to the non-returning handler pattern (pOnError) by using fire-and-settle instead of awaiting handler completion, and account for the new error callback passed to serverServe.
* Add test for "ui5 --version" * Add test for "ui5 build" (currently testing a TS application) Currently, those tests are not included in any CI pipeline and also need a manual "npm install" (no node_modules included yet).
+ Include "npm install" in test runtime
+ Refactor test environment for better reuse + Extend typescript test to cover Incremental Build
+ Add "application.a" (Javascript project fixture)
Co-authored-by: Copilot <copilot@github.com>
Break long test names to multiple lines to meet max-len 120 limit
d3xter666
force-pushed
the
remove-legacy-middlewares
branch
from
0bfc922 to
09a4670
Compare
- Remove cacache dependency from packages/project/package.json - Restore internal/e2e-tests/ files that were incorrectly deleted - Update package-lock.json to match base branch
maxreichmann
force-pushed
the
feat/incremental-build-4
branch
from
7aa4cd3 to
95fd5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-1206