cap nCount_ADT axis to 25000 in diagnostic plots #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
this is great, feel free to merge! |
Collaborator
Author
|
I'll merge pending a test on real data! (Since I've only used a version of the fix via running a separate script and haven't yet tested via the pipeline with this PR-branch.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple update: Uses
x/ylimto enforce [0,25000] as range for "nCount_ADT" axes of diagnostic plots.Current issue: I've found most of my CITEseq libraries to have handfuls of outlier cells that have values in the hundreds of thousand range for this metric whereas the bulk of most cells will fall into the 1,000-15,000 range. This common phenomenon causes the bulk of the data to be shrunk into a sliver at the lower end of this axis, which then effectively renders the plots unusable for their intended purpose -- allowing the user dial in a cutoff. The range of values where a cutoff might be drawn from ends up have very little resolution.
The fix here: This PR adjusts the function used for scatterplot creation to enforce axis limits of 0 to 25,000 for "nCount_ADT"-axes.