Skip to content

Conversation

@erflynn
Copy link
Collaborator

@erflynn erflynn commented Mar 19, 2024

This (overdue) PR accomplishes three things:
(1) additional nextflow set up options (see PR #60 for details)
(2) adding the fmx_assign_to_gt module (see PR #44 for details)
(3) fixing several bugs in the VDJ process to get it to a working version (which @dtm2451 is currently improving)

The previous PRs have not been resolved because of several key things:

  • we have yet to add tests for these new functionalities (I have not had the time to do a deep dive into nf-test)
  • the nextflow workflow logic could be cleaner
  • there are additional improvements for the nextflow set up that we want to make.

I am proposing we incorporate this into main and move these to-dos to issues because this is a much better working version, even though these are patches. I have confirmed that these changes do not break previous functionality.
What are folks' thoughts here?

erflynn and others added 30 commits November 1, 2023 14:11
…nes into ef/fmx_assign_to_gt

Pulling demuxlet and additional fixes
… run script to address problems with incorrect cleanup after external cancellation. also moved test queue settings to compute.config
Added suggestions from @dtm2451
Now contains the "[ ]" lists introduced by Amadeo's update
Also mentions the data types must be one of "CITE" or "GEX" (not both) and optionally any other modality, and provides examples
@erflynn
Copy link
Collaborator Author

erflynn commented May 23, 2024

update @dtm2451:
@amadeovezz and I met today to track down the testing error -- it appears that the only difference is that the snapshots now have stdout but did not before, so the tests were failing -- see commit 35ebc24 -- but the outputs of the pipeline are identical. Will go ahead and merge into main tomorrow.

reversed columns for read in of latest bcftools version
@erflynn erflynn merged commit c6bdf2f into main May 23, 2024
@erflynn erflynn deleted the ef/sc-dev branch December 5, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants