-
Notifications
You must be signed in to change notification settings - Fork 1
Incorporate major changes from single cell dev branch into main #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nes into ef/fmx_assign_to_gt Pulling demuxlet and additional fixes
…o finish instead of terminate
… run script to address problems with incorrect cleanup after external cancellation. also moved test queue settings to compute.config
Added suggestions from @dtm2451
…nes into ef/add_vdj_v2
Now contains the "[ ]" lists introduced by Amadeo's update Also mentions the data types must be one of "CITE" or "GEX" (not both) and optionally any other modality, and provides examples
…separately pulling from the same channel
…ocessing_pipelines into ef/add_vdj_v2
…nes into ef/add_vdj_v2
Collaborator
Author
|
update @dtm2451: |
reversed columns for read in of latest bcftools version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (overdue) PR accomplishes three things:
(1) additional nextflow set up options (see PR #60 for details)
(2) adding the
fmx_assign_to_gtmodule (see PR #44 for details)(3) fixing several bugs in the VDJ process to get it to a working version (which @dtm2451 is currently improving)
The previous PRs have not been resolved because of several key things:
I am proposing we incorporate this into main and move these to-dos to issues because this is a much better working version, even though these are patches. I have confirmed that these changes do not break previous functionality.
What are folks' thoughts here?