Allow negative Register reset values#464
Conversation
Pass bitwidth to `infer_val_and_bitwidth` in Register.__init__ to allow negative Register reset values
|
Thank you for your contribution! This change looks good to me, but you'll need to fix the test failures before we can merge it. Please also add a test for the new behavior so we can make sure it doesn't regress. Thanks again! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #464 +/- ##
=============================================
- Coverage 91.9% 91.9% -0.0%
=============================================
Files 24 24
Lines 6417 6417
=============================================
- Hits 5893 5892 -1
- Misses 524 525 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fdxmw
left a comment
There was a problem hiding this comment.
Thank you for your patience, we are almost there, these should be my last comments :)
There are also a couple pycodestyle errors on this pull request that will need to be fixed:
pyrtl/helperfuncs.py:807:101: E501 line too long (103 > 100 characters)
pyrtl/helperfuncs.py:808:25: E131 continuation line unaligned for hanging indent
Pass bitwidth to
infer_val_and_bitwidthin Register.init to allow negative Register reset values